Skip to content

Conversation

@parlough
Copy link
Member

Resolves the following warning on rebuilding the generated file, by relying on specifying the default value in the constructor.

[WARNING] json_serializable on lib/data/advisories_api.dart:
The constructor parameter for `aliases` has a default value `const <String>[]`, but the `JsonKey.defaultValue` value `[]` will be used for missing or `null` values in JSON decoding.

@isoos isoos requested a review from szakarias October 13, 2024 20:55
@jonasfj
Copy link
Member

jonasfj commented Oct 14, 2024

I'd be surprised if this has any impact.

It's only if we create these objects from JSON and then try to append to aliases.

@jonasfj jonasfj merged commit ba5b411 into dart-lang:master Oct 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants